Skip to content

chore(CI): add gci formatter #20179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

Elbehery
Copy link
Member

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.28%. Comparing base (52ce705) to head (b64a02a).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/osutil/interrupt_unix.go 81.48% <ø> (ø)

... and 45 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20179      +/-   ##
==========================================
+ Coverage   68.41%   69.28%   +0.87%     
==========================================
  Files         408      413       +5     
  Lines       34167    34367     +200     
==========================================
+ Hits        23375    23812     +437     
+ Misses       9385     9163     -222     
+ Partials     1407     1392      -15     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ce705...b64a02a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery Elbehery force-pushed the 20250617-add-gci-formatter branch from 3b82bae to b64a02a Compare June 17, 2025 12:02
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @Elbehery

cc @ivanvc @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @Elbehery

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, Elbehery, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 5dfd6e0 into etcd-io:main Jun 18, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants