Skip to content

refactor: use slices.Contains to simplify code #20185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xiaoxiangirl
Copy link

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Signed-off-by: xiaoxiangirl <caojiaqiao@outlook.com>
@k8s-ci-robot
Copy link

Hi @xiaoxiangirl. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jun 20, 2025

/ok-to-test

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.53%. Comparing base (5dfd6e0) to head (745f31c).
Report is 4 commits behind head on main.

Additional details and impacted files

see 155 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20185      +/-   ##
==========================================
- Coverage   69.10%   62.53%   -6.57%     
==========================================
  Files         410      401       -9     
  Lines       34232    33295     -937     
==========================================
- Hits        23656    20822    -2834     
- Misses       9166    10911    +1745     
- Partials     1410     1562     +152     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfd6e0...745f31c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, xiaoxiangirl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants