-
Notifications
You must be signed in to change notification settings - Fork 10.1k
refactor: use slices.Contains to simplify code #20185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: xiaoxiangirl <caojiaqiao@outlook.com>
Hi @xiaoxiangirl. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 155 files with indirect coverage changes @@ Coverage Diff @@
## main #20185 +/- ##
==========================================
- Coverage 69.10% 62.53% -6.57%
==========================================
Files 410 401 -9
Lines 34232 33295 -937
==========================================
- Hits 23656 20822 -2834
- Misses 9166 10911 +1745
- Partials 1410 1562 +152 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, xiaoxiangirl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.