Skip to content

Treat future revision as client error #20193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

serathius
Copy link
Member

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (5dfd6e0) to head (be6e482).
Report is 4 commits behind head on main.

Additional details and impacted files

see 30 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20193      +/-   ##
==========================================
+ Coverage   69.10%   69.30%   +0.19%     
==========================================
  Files         410      413       +3     
  Lines       34232    34367     +135     
==========================================
+ Hits        23656    23818     +162     
+ Misses       9166     9156      -10     
+ Partials     1410     1393      -17     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfd6e0...be6e482. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshjms
Copy link
Member

joshjms commented Jun 19, 2025

/retest

Copy link
Member

@joshjms joshjms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me

@serathius
Copy link
Member Author

/cc @ahrtr

@k8s-ci-robot k8s-ci-robot requested a review from ahrtr June 20, 2025 08:02
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, joshjms, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit f4ecf54 into etcd-io:main Jun 20, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Don't treat client error same way as server error.
4 participants