-
Notifications
You must be signed in to change notification settings - Fork 635
Align Cinder-plugin Helm Chart Labels with recommended ones by K8s. #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @jonitich! |
Hi @jonitich. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jonitich: GitHub didn't allow me to request PR reviews from the following users: jonitich. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern I have with this is that this would have to be a major release bump, due to the fact that mismatching labels will make it so things cannot deploy anymore.
hi @mnaser, yes indeed, changing those labels will make a rollout restart of the pods due to pod labels' immutability. |
What this PR does / why we need it: Aligning labels to Kubernetes standard ones. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: