-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-2837: Beta Graduation Criteria for 1.34 #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user attempts to configure scope=container for such a pod
Topology Manager scope (container/pod) is a node level setting.
3da0389
to
471221b
Compare
/sig autoscaling |
b776557
to
3f3e191
Compare
/assign @tallclair |
3f3e191
to
5e556cc
Compare
5fb75de
to
04f28d7
Compare
04f28d7
to
7a26908
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ndixita, sanposhiho The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7a26908
to
5773936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
5773936
to
5b51362
Compare
5b51362
to
1d8e4df
Compare
Can we summarize in the description and/or the commit message the proposed changes (some are lost in the discussion threads)? |
/lgtm |
Signed-off-by: ndixita <ndixita@google.com>
1d8e4df
to
83bf364
Compare
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 PRR questions (tests for enablement/disablement, upgrade->downgrade->upgrade and new fields estimation) are the remaining blocking items.
- apiserver_rejected_requests | ||
- schedule_attempts_total{result="error|unschedulable"} | ||
- node_collector_evictions_total` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- node_collector_evictions_total` | |
- node_collector_evictions_total |
- node_collector_evictions_total` | ||
- started_pods_errors_total | ||
- started_containers_errors_total` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- started_containers_errors_total` | |
- started_containers_errors_total |
@@ -71,7 +72,7 @@ | |||
- [Implementation History](#implementation-history) | |||
- [Drawbacks](#drawbacks) | |||
- [Alternatives](#alternatives) | |||
- [VPA](#vpa) | |||
- [VPA](#vpa-1) | |||
<!-- /toc --> | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to include the second one in the release, it's currently missing lead-opted-in
label and milestone set. This needs to be done by sig-node leads.
* Cgroup settings when pod-level resources are set. | ||
* Validate scheduling and admission. | ||
* Validate the containers with no limits set are throttled on CPU when CPU usage reaches Pod level CPU limits. | ||
* Validate the containers with no limits set are OOMKilled when memory usage | ||
reaches Pod level memory limits. | ||
* Test the correct values in TotalResourcesRequested. | ||
|
||
- [test name](https://github.com/ndixita/kubernetes/blob/master/test/e2e/common/node/pod_level_resources.go): [SIG Node](https://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-e2e-podresources), [triage search](https://storage.googleapis.com/k8s-triage/index.html?ci=0&pr=1&sig=node&job=pull-kubernetes-node-kubelet-serial-podresources) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [test name](https://github.com/ndixita/kubernetes/blob/master/test/e2e/common/node/pod_level_resources.go): [SIG Node](https://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-e2e-podresources), [triage search](https://storage.googleapis.com/k8s-triage/index.html?ci=0&pr=1&sig=node&job=pull-kubernetes-node-kubelet-serial-podresources) | |
- [Pod Level Resources](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/node/pod_level_resources.go): [SIG Node](https://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-e2e-podresources), [triage search](https://storage.googleapis.com/k8s-triage/index.html?ci=0&pr=1&sig=node&job=pull-kubernetes-node-kubelet-serial-podresources) |
`k8s.io/kubernetes/pkg/kubelet/cm`: `20250618` - 18.4 | ||
`k8s.io/kubernetes/pkg/kubelet/kuberuntime`: `20250618` - 69.1 | ||
`k8s.io/kubernetes/pkg/scheduler/framework` - `20250618` - 71.7 | ||
`k8s.io/kubernetes/pkg/apis/core/validation` - `20250618` - 84.7 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason you're missing integration tests? If none are applicable, please make sure to add such information.
* Pod Level Resources Support With In Place Pod Vertical Scaling KEP is past alpha. | ||
* User feedback (ideally from at least two distinct users) is green | ||
* Resource Allocation Managers i.e. Topology, Memory and CPU managers support with | ||
Pod-level resources is past alpha. | ||
|
||
### Upgrade / Downgrade Strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In
###### Are there any tests for feature enablement/disablement?
you're describing tests that were planned for alpha, can you add there links to those tests? ###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
is missing answers, it currently mentions only that it will be tested? Was it? Can you describe the steps?- In
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
you're missing estimated size increase, and amount of new objects (see comments above that section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for SIG-Autoscaling
method. | ||
Collaboration with sig-autoscaling has been established to integrate support for | ||
VPA with Pod-level resources, slated for VPA 1.5. The changes to support pod-level | ||
resources in VPA will be worked on in two phases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - you can remove the "two phases" part
Uh oh!
There was an error while loading. Please reload this page.