-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-2033: KubeletInUserNamespace: update the template; promote to beta #5388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
AkihiroSuda
commented
Jun 8, 2025
- One-line PR description: Rootless Kubernetes
- Issue link: sig-node: Kubelet-in-UserNS, aka Rootless mode #2033
- Other comments: The first commit only updates the template. The actual content is updated in the second commit.
This comment was marked as resolved.
This comment was marked as resolved.
Only the template is updated in this commit. The actual content will be updated in follow-up commits. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AkihiroSuda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,3 +1,5 @@ | |||
kep-number: 2033 | |||
alpha: | |||
approver: "@ehashman" | |||
beta: | |||
approver: "@ehashman" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ehashman May I put your name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need to find a new approver for this. I think ehashman has stepped down from PRR duties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use my name, I'll take this one over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still holds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple PRR questions not answered.
@@ -15,7 +15,7 @@ reviewers: | |||
- "@dims" | |||
- "@sftim" | |||
approvers: | |||
- TBD | |||
- "@ehashman" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elena was approving the PRR section, so she's a separate entry in 2033.yaml. Here you'll need someone who actually approved this document. It seems last time it was Derek, not sure who will be approving it this time, but it has to be someone from sig-node.
- [ ] (R) Production readiness review completed | ||
- [ ] Production readiness review approved | ||
- [ ] (R) Production readiness review approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're targeting a beta release, and thus this functionality will be on by default. I'd expect several of the above be ✔️
@@ -1,3 +1,5 @@ | |||
kep-number: 2033 | |||
alpha: | |||
approver: "@ehashman" | |||
beta: | |||
approver: "@ehashman" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still holds.
extending the production code to implement this enhancement. | ||
--> | ||
|
||
N/A, as unit tests do not make sense here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're touching kubelet, at minimum I'd expect information about current unit coverage for the affected area.
``` | ||
|
||
- Prow manifest: https://github.com/kubernetes/test-infra/blob/4b7824ff1cfe00c36062035ab6aea3bb6c2e6ba2/config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml#L615-L678 | ||
- Logs: https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-kind-rootless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of integration and/or e2e residing in k8s repository makes me worry about the stability of this functionality. How can we ensure this is working correctly, if there are no tests? This introduces a risk that if someone introduces a breaking change we won't notice it until somewhere else that test is being run.
implementation difficulties, etc.). | ||
--> | ||
|
||
N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, No - here is perfectly reasonable answer.
|
||
No. | ||
|
||
* **Will enabling / using this feature result in non-negligible increase of | ||
resource usage (CPU, RAM, disk, IO, ...) in any components?** | ||
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing answer.
|
||
RootlessKit and slirp4netns may face high CPU and memory consumption. | ||
|
||
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing answer.
@@ -804,6 +1161,7 @@ Major milestones might include: | |||
- 2019-11-19: @giuseppe submitted [cgroup v2 KEP](https://github.com/kubernetes/enhancements/pull/1370) | |||
- 2019-11-19: present KEP to SIG-node (cgroup v2 version) | |||
- 2020-07-07: the cgroup v2 support is in `implementable` status | |||
- 2021-08-04: Kubernetes v1.22 (Alpha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing current update here in the history as well.
|
||
# The milestone at which this feature was, or is targeted to be, at each stage. | ||
milestone: | ||
alpha: "v1.22" | ||
beta: "v1.34" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below in the doc, you're missing metrics section, see template.