Skip to content

KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements #5409

wants to merge 2 commits into from
+87 −116

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Jun 11, 2025 •
edited
Loading

  • One-line PR description: Split the two phases into two KEPs to allow them moving at different paces. This original KEP (4205) will keep tracking the implemented exposure of PSI metrics. See KEP-5394: PSI-based node conditions #5395 for more details. Also update Alpha and Beta requirements.

/sig node
/cc @haircommander @ndixita @tiraboschi

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ndixita June 11, 2025 22:10
@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: tiraboschi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

  • One-line PR description: Split the two phases into two KEPs to allow them moving at different paces. See KEP-5394: PSI-based node conditions #5395 for more details. Also update Alpha and Beta requirements. Make CPU PSI a Beta requirement

/sig node
/cc @haircommander @ndixita @tiraboschi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2025
This was referenced Jun 11, 2025
Open
Open
@lmktfy
Copy link

lmktfy commented Jun 11, 2025

/retitle KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements

@k8s-ci-robot k8s-ci-robot changed the title 4205: Split the two phases into two KEPs and update Alpha and Beta requirements KEP-4205: Split the two phases into two KEPs and update Alpha and Beta requirements Jun 11, 2025
@roycaihw roycaihw force-pushed the psi-condition-updates branch 2 times, most recently from b399df8 to 1757134 Compare June 17, 2025 00:23
This was referenced Jun 17, 2025
Open
Merged
@roycaihw
Copy link
Member Author

@haircommander I've updated the two KEPs as suggested. PTAL

haircommander
haircommander reviewed Jun 17, 2025
View reviewed changes
@haircommander
Copy link
Contributor

one note but generally this LGTM

kannon92
kannon92 reviewed Jun 17, 2025
View reviewed changes
kannon92
kannon92 reviewed Jun 17, 2025
View reviewed changes
@kannon92
Copy link
Contributor

PRR shadow:

deads2k
deads2k reviewed Jun 18, 2025
View reviewed changes
@deads2k
Copy link
Contributor

deads2k commented Jun 18, 2025

PRR lgtm.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, roycaihw
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander
haircommander reviewed Jun 18, 2025
View reviewed changes
keps/sig-node/4205-psi-metric/kep.yaml

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
feature-gates:
- name: PSINodeCondition
- name: KubeletPSI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity: this was already done for alpha, we're not changing the feature gate name

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
mrunalp
mrunalp reviewed Jun 18, 2025
View reviewed changes
keps/sig-node/4205-psi-metric/README.md
- Initial e2e tests completed and enabled if CRI implementation supports
it.
- Add documentation for the feature.

#### Beta

- Feature gate is enabled by default.
- Extend e2e test coverage.
- Allowing time for feedback.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we gathered any performance implications of enabling and gather PSI? Will there be a knob for turning this on/off?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no knob once this goes GA, though I do agree there should be perf testing done. When CRI stats comes along, technically the CRI implementation could be configured whether to report PSI metrics or not. We also could introduce a knob in the kubelet config, as CRI stats has been "coming" for years now...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another thing to consider--if the node has psi off but cadvisor is trying to collect the metrics, what happens?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added performance testing to the beta requirements. PTAL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roycaihw I don't see it in the beta list above.

@roycaihw
Update the KEP with Beta requirements
ec090f0 
Also update the KEP to reflect the Alpha implementation details
@roycaihw roycaihw force-pushed the psi-condition-updates branch from 7135412 to ec090f0 Compare June 18, 2025 23:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@kannon92 kannon92 kannon92 left review comments

@deads2k deads2k deads2k left review comments

@haircommander haircommander haircommander left review comments

@ndixita ndixita Awaiting requested review from ndixita

Assignees

@haircommander haircommander

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@roycaihw @k8s-ci-robot @lmktfy @haircommander @kannon92 @deads2k @mrunalp