-
Notifications
You must be signed in to change notification settings - Fork 8.4k
feat: run extraVolumes through templating #13596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kyrremann The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @Kyrremann! |
Hi @Kyrremann. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We wanted to add custom error pages for our load balancer, and since each load balancer depence on their own ingress-nginx we need to be able to template the volume configmap. ``` extraVolumes: - name: custom-error-pages configMap: name: "{{ .Release.Name }}-custom-error-pages" ``` Now gives us: ``` volumes: - configMap: name: '{{ .Release.Name }}-custom-error-pages' ```
What this PR does / why we need it:
We wanted to add custom error pages for our load balancer, and since each load balancer dependens on their own ingress-nginx we need to be able to template the volume configmap.
Now gives us:
Types of changes
How Has This Been Tested?
I've added a Helm chart test that covers my explicit change.
Checklist: