-
Notifications
You must be signed in to change notification settings - Fork 5k
WIP: remove podman-env #20884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP: remove podman-env #20884
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LJTian The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @LJTian. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
"github.com/google/go-cmp/cmp" | ||
) | ||
|
||
func newFakeClient() *ssh.ExternalClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not need to do these Tests anymoe ? do we have a dpulicate of these test for docker-env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relevant content will be added in docker-env_test.go.
My understanding is not detailed enough and needs further modification. The current version is not the correct version.
fix: #20828