Skip to content

fix wrong reference link of kubelet #51282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix wrong reference link of kubelet #51282

wants to merge 1 commit into from

Conversation

B1F030
Copy link
Contributor

@B1F030 B1F030 commented Jun 16, 2025 •
edited
Loading

Description

Issue

Part of: #51280

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Jun 16, 2025
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 16, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e89ac54
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68522f0349171b0008f6db07
😎 Deploy Preview https://deploy-preview-51282--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

windsonsea
windsonsea reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the English upstream source first, and then proceed with localizations such as zh-cn.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language labels Jun 17, 2025
@B1F030
Copy link
Contributor Author

B1F030 commented Jun 17, 2025

Please update the English upstream source first, and then proceed with localizations such as zh-cn.

Thanks. Since en link works fine, I thought en version was correct, so I didn't check it at first.

@windsonsea
Copy link
Member

windsonsea commented Jun 17, 2025 •
edited
Loading

You only need include a language (such as english) in a PR, and let localization teams to handle other variants.

@B1F030
fix wrong reference link of kubelet
e89ac54 
Signed-off-by: B1F030 <b1fzhang@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@B1F030 B1F030 changed the title [zh]fix wrong reference link of kubelet fix wrong reference link of kubelet Jun 18, 2025
@windsonsea
Copy link
Member

/remove-language zh
/unhold

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language labels Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@SataQiu SataQiu Awaiting requested review from SataQiu

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B1F030 @windsonsea @k8s-ci-robot