Skip to content

[bug]: fix <Select> to use Peregrine's "useInformedFieldStateWrapper" like other form inputs do #4381

Open
@brendanfalkowski

Description

@brendanfalkowski
Contributor

Describe the bug

In 2021, this PR was created to suppress a noisy warning from the informed form library:
#3399

A new hook useInformedFieldStateWrapper was created which wraps Informed's useFieldState. Instances of useFieldState were modified to use the new hook:

  • Checkbox
  • RadioGroup
  • TextArea
  • TextInput
  • ...and a bunch of hooks (useQuantity, usePaymentMethods, usePostcode, useRegion, useSearchField, useAutocomplete)

See file changes: https://github.com/magento/pwa-studio/pull/3399/files

Not sure why, but Select form inputs in Venia UI were excluded from this change in that PR. There's no mention of why. It still uses useFieldState directly from Informed, which causes the same noisy warnings.

To reproduce

Observed in our custom application. I don't think this happens in the Venia demo.

Adding a <Select> input in our footer causes these console warnings on load.

Possible solutions

Fix it by using useInformedFieldStateWrapper in Select.

Please let us know what packages this bug is in regards to:

  • venia-concept
    venia-ui
    pwa-buildpack
    peregrine
    pwa-devdocs
    upward-js
    upward-spec
    create-pwa

Activity

m2-assistant

m2-assistant commented on Jan 29, 2025

@m2-assistant

Hi @brendanfalkowski. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

brendanfalkowski

brendanfalkowski commented on Jan 29, 2025

@brendanfalkowski
ContributorAuthor

@magento I am working on this

m2-assistant

m2-assistant commented on Jan 29, 2025

@m2-assistant

Hi @brendanfalkowski! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

brendanfalkowski

brendanfalkowski commented on Jan 29, 2025

@brendanfalkowski
ContributorAuthor

@magento add to contributors team

m2-assistant

m2-assistant commented on Jan 29, 2025

@m2-assistant

Hi @brendanfalkowski! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

brendanfalkowski

brendanfalkowski commented on Jan 29, 2025

@brendanfalkowski
ContributorAuthor

@magento I am working on this

glo82145

glo82145 commented on May 27, 2025

@glo82145
Collaborator

@adobe export issue to Jira project PWA

github-jira-sync-bot

github-jira-sync-bot commented on May 27, 2025

@github-jira-sync-bot

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3463 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @brendanfalkowski@github-jira-sync-bot@glo82145

    Issue actions

      [bug]: fix <Select> to use Peregrine's "useInformedFieldStateWrapper" like other form inputs do · Issue #4381 · magento/pwa-studio