Skip to content

[bug]: fix Yarn invariant violation caused by "packages/pagebuilder" requesting different version of "react-tabs" #4468

Open
@brendanfalkowski

Description

@brendanfalkowski

Describe the bug

When running yarn install, Yarn throws an invariant violation and fails to install.

I traced this down to packages/pagebuilder/package.json which defines:

"devDependencies": {
  ...
  "react-tabs": "~3.0.0"
},
"peerDependencies": {
  ...
  "react-tabs": "~3.1.0"
}

This breaks Yarn workspaces because it can't resolve to a single version.

Expected behavior

Yarn can install.

Possible solutions

I will submit a PR.

There isn't a breaking change between react-tabs 3.0.0 and 3.1.0. It only added LTR locale support.

The Pagebuilder package should define both dependencies with 3.1.0, so Yarn works.

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pagebuilder
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions