Skip to content

PWA-4468: use the same version of react-tabs everywhere #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brendanfalkowski
Copy link
Contributor

@brendanfalkowski brendanfalkowski commented Jun 20, 2025

Description

When running yarn install, Yarn throws an invariant violation and fails to install.

I traced this down to packages/pagebuilder/package.json which defines:

"devDependencies": {
  ...
  "react-tabs": "~3.0.0"
},
"peerDependencies": {
  ...
  "react-tabs": "~3.1.0"
}

This breaks Yarn workspaces because it can't resolve to a single version.

Related Issue

Closes #4468

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@brendanfalkowski
Copy link
Contributor Author

brendanfalkowski commented Jun 20, 2025

Note: I did not commit the yarn.lockfile because there were too many other changes.

I'll let the Adobe team decide how to incorporate that.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 65e05fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: fix Yarn invariant violation caused by "packages/pagebuilder" requesting different version of "react-tabs"
2 participants