Skip to content

Map rollback across remote ops prototype #24822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ChumpChief
Copy link
Contributor

Putting this up as draft prototype for visibility, but I want to spend a little more time thinking about splitting pending op tracking from the pending data tracking. Also needs testing for the new scenarios and some basic cleanup.

A few known/intentional behavior changes to consider:

  • I early exit for delete() when it would be a no-op for the local client, rather than sending a speculative delete op.
  • I don't emit events for re-adding items in response to processing a clear while pending ops are outstanding (basically un-fixes AB 411). I should probably emit events for the deleted keys though at least - I think this would probably be the most expected behavior and was previously considered as an alternative resolution to 411.
  • Now has consistent iteration ordering between clients, at least after outstanding ops settle, which was not guaranteed before.
  • One of the stress tests passes now.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant