-
Notifications
You must be signed in to change notification settings - Fork 548
build(client): Bump server dependencies to 6.0.0 #24857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps server dependency versions from 5.0.0 to 6.0.0 across various client packages to support the latest server functionality.
- Update dependency "tinylicious" in multiple packages
- Update server-related dependencies such as "@fluidframework/server-services-client", "@fluidframework/server-local-server", and others
- Ensure consistent version alignment across client and example projects
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/service-clients/end-to-end-tests/azure-client/package.json | Updated "tinylicious" version |
packages/framework/client-logger/fluid-telemetry/package.json | Updated "tinylicious" version |
packages/drivers/routerlicious-driver/package.json | Updated "@fluidframework/server-services-client" version |
packages/drivers/local-driver/package.json | Updated protocol and server-related dependencies versions |
experimental/PropertyDDS/packages/property-dds/package.json | Updated "@fluidframework/server-local-server" version |
examples/view-integration/external-views/package.json | Updated "@fluidframework/server-local-server" version |
examples/version-migration/tree-shim/package.json | Updated "tinylicious" version |
examples/version-migration/separate-container/package.json | Updated "@fluidframework/server-local-server" version |
examples/utils/webpack-fluid-loader/package.json | Updated "@fluidframework/server-local-server" version |
examples/utils/migration-tools/package.json | Updated "@fluidframework/server-local-server" version |
examples/utils/example-utils/package.json | Updated "@fluidframework/server-local-server" version |
examples/service-clients/azure-client/external-controller/package.json | Updated both "@fluidframework/server-local-server" and "tinylicious" versions |
examples/external-data/package.json | Updated "tinylicious" version |
examples/client-logger/app-insights-logger/package.json | Updated "tinylicious" version |
examples/benchmarks/tablebench/package.json | Updated "tinylicious" version |
examples/apps/staging/package.json | Updated "@fluidframework/server-local-server" version |
examples/apps/presence-tracker/package.json | Updated "tinylicious" version |
examples/apps/blobs/package.json | Updated "@fluidframework/server-local-server" version |
examples/apps/ai-collab/package.json | Updated "tinylicious" version |
azure/packages/azure-local-service/package.json | Updated "tinylicious" version |
exclude: (instance) => | ||
// @fluidframework/server-services-client pulls in uuid 11.1.0, and thus bundles using it get this package duplicated until the version of uuid in client gets updated. | ||
// TODO: Remove this when uuid is bumped in client packages | ||
instance.name === "uuid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comment seems to be referring to client deps, not server deps. Are you sure this upgrade also changes the client version of uuid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that comment is a bit clunky, let me clarify - The new server packages use uuid ^11.1.0
but client packages are still pulling in ^9.0.1
. This PR does not bump the client packages so we are pulling in both versions of the uuid package. I added the uuid package to exclude
so that we can check-in the server bump and then we can bump uuid in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, got it. I suggest updating the comment to include those details. You can even include version numbers. "server packages v6.0.0 use uuid v.... Once client dependendices on UUID are updated to version xxxx, this can be removed" etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus points, file a tracking issue and include the bug number.
Bumps server dependencies in client packages to 6.0.0