[NOT FOR MERGING] Use persisted metadata in ai-collab sample app #24862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added in-memory schema format v2. - Implemented the schema format v2 codec. - Updated test utils that previously assumed there was only one format. - Added snapshots for many of the v2 tests.
…ion as a parameter. - Fixed naming of schema index formats. - Changed schemaChangeFormat to be schema format-agnostic.
…formats. - Moved SchemaCodecVersion.
Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
… we want something more intuitive (e.g., minimum client version). - Split the encode method for TreeNodeStoredSchema.
…luidFramework into metadata-schema-3
…cVersion. - Changed schema-stored/FormatV2 to only define the new elements. - Updated all instantiations of TreeFieldStoredSchema so that persistedMetadata is specified. - HACK: importCompressed needs to handle both schema formats. A few of the roundtrip JSON tests are failing.
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
- Made importCompressed always use a v1 schema when encoding.
- Added better test data to one of the codec tests for the v2 schema format.
…added in another PR. - Updated a comment.
- Added tests calling schemaFactoryAlpha.
Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
- Moved JsonCompatibleReadOnly and JsonCompatibleReadOnlyObject to alpha API status so they can be used in schemas - Implemented field factory methods and added test coverage - Added requiredRecursive to schemaFactoryAlpha (not sure if it should be part of this change though)
…involving FormatV2.
…metadata. - Fixed a bug where FormatV2 was including FormatV1 fields. - persistedMetadata is now only written when non-undefined. - simple-tree implementations for individual schema kinds (arrayNode, mapNode, objectNode) now pass persistedMetadata down from the outer factory calls. - Introduced alpha APIs for simple-tree in places where we need to pass persistedMetadata but don't want to pollute the public API. - Updated tests to pass persistedMetadata when constructing SimpleNodeSchemas. - Wrote simple tests for node and field persisted metadata.
github-actions
bot
added
area: dds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just creating so we can see the diff of things I did to the ai-collab sample app to use persisted metadata while we were working on a version of those changes in SharedTree.