Skip to content

[v2.50] Remove IFluidHandleInternal.bind #24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 3, 2025
Merged

Conversation

markfields
Copy link
Member

@markfields markfields commented Jun 18, 2025

Fixes #24557

Description

IFluidHandleInternal.bind was deprecated in 2.40 (via #24553), see release notes entry for more details.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Jun 18, 2025
All legacy-alpha and backCompat breaking only (not forwardCompat)
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Jun 18, 2025
@markfields markfields force-pushed the test/remove-handle-bind-fn branch from eba7b09 to bc259b2 Compare June 19, 2025 00:08
@markfields markfields marked this pull request as ready for review June 30, 2025 14:50
@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 14:50
@markfields markfields requested review from a team as code owners June 30, 2025 14:50
@markfields
Copy link
Member Author

@jason-ha -- This should be ready to go into 2.50, if you're willing to merge it while I'm out. Thanks! cc @agarwal-navin

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated IFluidHandleInternal.bind API across multiple packages in preparation for the v2.50 breaking release. It cleans up method implementations and interface declarations, updates compatibility tests to expect failures where back-compat is broken, and revises API reports and type-validation configs to reflect the removal.

  • Removed all bind method declarations and implementations from handles, remote handles, blob manager, and core interfaces.
  • Updated generated compatibility tests (validate*Previous.generated.ts) with // @ts-expect-error for broken back-compat scenarios.
  • Extended typeValidation.broken sections in various package.json files and cleaned up API report markdowns to remove deprecated entries.

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/test/test-utils/src/test/types/validateTestUtilsPrevious.generated.ts Added // @ts-expect-error for the two broken interface compat checks.
packages/test/test-utils/package.json Populated typeValidation.broken with the deprecated interface entries.
packages/test/test-end-to-end-tests/src/test/gc/gcUnknownHandles.spec.ts Removed IFluidHandle import and the deprecated bind override in TestFluidHandle.
packages/runtime/runtime-utils/src/handles.ts Deleted the abstract bind method from FluidHandleBase.
packages/common/core-interfaces/src/handles.ts Removed the deprecated bind method from IFluidHandleInternal.
packages/runtime/runtime-utils/src/remoteFluidObjectHandle.ts Eliminated the bind override and its associated import of fail.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  207095 links
    1443 destination URLs
    1673 URLs ignored
       0 warnings
       0 errors


Copy link
Contributor

@agarwal-navin agarwal-navin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jason-ha jason-ha enabled auto-merge (squash) July 2, 2025 23:14
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look good

@jason-ha jason-ha merged commit 7cdef85 into main Jul 3, 2025
39 checks passed
@jason-ha jason-ha deleted the test/remove-handle-bind-fn branch July 3, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IFluidHandleInternal.bind function
4 participants