-
Notifications
You must be signed in to change notification settings - Fork 552
[v2.50] Remove IFluidHandleInternal.bind #24870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It will be removed from FluidObjectHandle when bind is removed from the interface
All legacy-alpha and backCompat breaking only (not forwardCompat)
eba7b09
to
bc259b2
Compare
@jason-ha -- This should be ready to go into 2.50, if you're willing to merge it while I'm out. Thanks! cc @agarwal-navin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated IFluidHandleInternal.bind
API across multiple packages in preparation for the v2.50 breaking release. It cleans up method implementations and interface declarations, updates compatibility tests to expect failures where back-compat is broken, and revises API reports and type-validation configs to reflect the removal.
- Removed all
bind
method declarations and implementations from handles, remote handles, blob manager, and core interfaces. - Updated generated compatibility tests (
validate*Previous.generated.ts
) with// @ts-expect-error
for broken back-compat scenarios. - Extended
typeValidation.broken
sections in variouspackage.json
files and cleaned up API report markdowns to remove deprecated entries.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/test/test-utils/src/test/types/validateTestUtilsPrevious.generated.ts | Added // @ts-expect-error for the two broken interface compat checks. |
packages/test/test-utils/package.json | Populated typeValidation.broken with the deprecated interface entries. |
packages/test/test-end-to-end-tests/src/test/gc/gcUnknownHandles.spec.ts | Removed IFluidHandle import and the deprecated bind override in TestFluidHandle . |
packages/runtime/runtime-utils/src/handles.ts | Deleted the abstract bind method from FluidHandleBase . |
packages/common/core-interfaces/src/handles.ts | Removed the deprecated bind method from IFluidHandleInternal . |
packages/runtime/runtime-utils/src/remoteFluidObjectHandle.ts | Eliminated the bind override and its associated import of fail . |
…ectHandle in tree where needed.
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API changes look good
Fixes #24557
Description
IFluidHandleInternal.bind
was deprecated in 2.40 (via #24553), see release notes entry for more details.