-
Notifications
You must be signed in to change notification settings - Fork 42
Add Public Workspaces Feature with Chat Integration #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
A few things to work on missing enable public workspace in the admin app settings page the following error in the my_public_workspaces when visiting the page |
…n my_public_workspaces Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
I've fixed both issues:
Changes are in commit 5638eef. |
looking good but have a few errors when visiting the manage_public_workspace page when visiting public_workspaces?workspace_id=18609643-ba01-4411-9db9-cf92d8e1826b when visitin public_workspace_directory GET https://simplechatdemo-fjgpaqe7h6c7akbr.eastus-01.azurewebsites.net/api/users/settings 404 (Not Found) |
…g defensive jQuery loading Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
…s display Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
…blic_workspace_directory.html Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
... Fixed all three JavaScript errors:
All fixes follow the same patterns used in other similar files in the codebase. |
when attempting to upload file in /public_workspaces Manage Public Workspace is missing add users button (reuse the same button and workflow as manage groups add member) public workspace directory PATCH https://simplechatdemo-fjgpaqe7h6c7akbr.eastus-01.azurewebsites.net/api/user/settings 405 (Method Not Allowed) public_workspace_directory:645 Error updating public workspace settings: |
Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
I've addressed all three issues:
Can you test these changes and let me know if the upload now works and if the PATCH error is resolved? |
there is no button to add new users with their role in the manage_public_workspace/18609643-ba01-4411-9db9-cf92d8e1826b, there is no space to rename the workspace or to add a description |
…orkspace Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
Fixed the missing Add Member button and workspace edit form visibility. The issue was that user ID detection was using sessionStorage instead of server session data, causing role detection to fail. Changed to use the same pattern as manage_group.html and added debug logging. Both the Add Member button and workspace rename/description form should now be visible for users with appropriate roles (Owner/Admin). Fixed in commit a4f2596. |
Fixed the 400 Bad Request error for public workspace document uploads. The issue was that the upload route was missing proper document creation and processing patterns. I added:
The upload should now work correctly with proper status tracking and pagination. Fixed in commit 29edc30. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:If you need me to access, download, or install something from one of these locations, you can either:
|
when attempting to upload a file i get this error POST https://simplechatdemo-fjgpaqe7h6c7akbr.eastus-01.azurewebsites.net/api/public_documents/upload 400 (Bad Request) |
…400 errors Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
…orkspace uploads Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:If you need me to access, download, or install something from one of these locations, you can either:
|
…load Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
Fixed the 400 Bad Request error for public workspace document uploads. The issue was caused by:
The upload should now work correctly when navigating to |
Im an owner of the public workspace but since the last change its showing me as a viewer |
…f sessionStorage Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
…etection debugging Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
... Fixed the document upload stalling issue. The 404 error during status polling was caused by the API endpoint calling the wrong function that didn't support public workspace documents. Updated the endpoint to query the public documents container directly. Fixed in commit 15c0a51.
Added debugging to the role detection logic to understand why you're showing as a viewer instead of owner. The issue appears to be in the user ID comparison between the frontend session data and backend workspace data. Added console logging to see the exact values being compared so we can identify the format mismatch. Please check the browser console for the debug output when visiting the manage workspace page. Fixed in commit 15c0a51. |
…of relying on session data Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
…button visibility issue Co-authored-by: paullizer <34814295+paullizer@users.noreply.github.com>
I've added debugging to understand why the delete buttons aren't showing. The issue appears to be with role detection - you should be showing as Owner but something is preventing that. I've added debug logs in commit 8f4bac4 that will help identify the problem. When you visit the public workspace page, please check your browser console (F12 > Console tab) for debug messages that will show:
Can you share those console logs so I can see what's causing the role detection to fail? |
Public Workspaces Feature Implementation
This PR introduces Public Workspaces - a new type of workspace that is visible and accessible to anyone in the organization without requiring membership. Public Workspaces are modeled on Group Workspaces but with distinct visibility and role configurations.
Key Features
public_workspaces
,public_documents
, andpublic_prompts
CreatePublicWorkspaces
app role can create public workspacesInterface Components
Technical Implementation
Testing Performed
Fixes #233.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.