Skip to content

Review the conditional compilations in ASPNET Core and other instrumentations. #1777

Open
@cijothomas

Description

@cijothomas

Due to the addition of more targets like net5.0 and net6.0 to the instrumention projects, the conditional checks inside the code seems broken now.

example:
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L313 check for
#if NETSTANDARD2_1, means that code path is not triggered for net5.0 or net6.0

Opening an issue to do a round of reviews to make sure the conditional compilation flags are still correct, after the addition of new project targets.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcomp:instrumentation.aspnetcoreThings related to OpenTelemetry.Instrumentation.AspNetCorehelp wantedExtra attention is neededinfraInfra work - CI/CD, code coverage, linters

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions