-
Notifications
You must be signed in to change notification settings - Fork 117
[Infra] Drop system versions from format-native jobs #4266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Drop system versions from format-native jobs #4266
Conversation
- Use the latest GitHub Actions runner OS versions for `format-native`. - Decouple the workflow status names from the OS version for easier long-term maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the GitHub Actions workflow for format-native to use the latest runner OS versions and decouple the runner names from the OS version details.
- Dynamically sets the job name using the matrix's os-name.
- Configures the workflow to run on new runner images by replacing the old machine list with an include block specifying new runner labels.
Comments suppressed due to low confidence (2)
.github/workflows/format-native.yml:15
- [nitpick] The use of the matrix OS name for the job name improves clarity; ensure that this naming style is applied consistently across similar workflows.
name: ${{ matrix.os-name }}
.github/workflows/format-native.yml:27
- Verify that 'windows-2025' is a supported runner label in GitHub Actions to avoid any unexpected runtime issues.
runner: windows-2025
@open-telemetry/dotnet-instrumentation-maintainers we'll need to update the |
I think that the new names will be easier for us to maintain especially now that our rulesets are controlled by settings in another repo. https://github.com/open-telemetry/admin/blob/main/repo-opentelemetry-dotnet-instrumentation.tf will need to be updated, and someone will need to figure out the migration process. |
I like changes related to the machine names. When fixed, we can easily manage machines without touching GitHub configuration. I have some doubts about updating machines. For now, all jobs are executes on the lowest supported version for each system. For me, it is easier to update all of them at once, but I can accept modern stuff only for code formatting. |
@trask, could you please advice what is the new procedure for updating GitHub configuration for the main branch protection? Should we fix it directly on GitHub or create PR to some repository? |
This PR came out of #4263 (comment). Need some feedback there on where 2025 should be additive and where it should be replacing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martincostello, I would like to only refactor names here, and keep executed system versions without changes.
For now, by convention, we are executing all tasks on the oldest supported version of each system.
Step rename - I need unique names to use in GitHub configuration. Without changes, I should put just linux
, windows
, and macos
into the code configuration.
Please let me know if you are fine with such changes.
Yep that's fine with me. The most important part of this change was to remove the OS version from the step names so they can be upgraded in the future without needing the repo settings changing again. |
Why
Keep pace with GitHub Actions infrastructure.
Required status checks will need updating to expect the new names that don't include the OS' version.
Old
New
Updated, after changes - @Kielek
What
format-native
.Tests
None.
Checklist
CHANGELOG.md
is updated.Documentation is updated.New features are covered by tests.