feat: Add AWS_SNS_TOPIC_ARN semantic convention support for AWS SNS SDK #14035
Conversation
MESSAGING_DESTINATION_NAME does not cover APIs like 'CreateTopic' which sets TopicArn on Response instead of Request. AWS_SNS_TOPIC_ARN is the generic semconv attribute for SNS Apis. |
lukeina2z
force-pushed
the
xy-foo-3-sns
branch
2 times, most recently
from
282e855 to
39fee7a
Compare
it seems ok based on this semconv tends to avoid conditionally setting the second one only when it's different |
| c.publish( | ||
| new PublishRequest().withMessage("somemessage").withTargetArn("somearn")))); | ||
| @Test | ||
| public void testCreateTopicRequestWithMockedResponse() throws Exception { |
There was a problem hiding this comment.
usually we add tests as package private methods
There was a problem hiding this comment.
access modifier removed. I think the default is package-private.
| @@ -32,47 +50,66 @@ protected boolean hasRequestId() { | |||
| return true; | |||
| } | |||
|
|
|||
| @ParameterizedTest | |||
| @MethodSource("provideArguments") | |||
| public void testSendRequestWithMockedResponse(Function<AmazonSNS, Object> call) throws Exception { | |||
There was a problem hiding this comment.
as far as I can tell you could have kept the original parameterized tests and just added the additionalAttributes as another parameter
There was a problem hiding this comment.
Good feedback. Thank you @laurit.
This PR adds the AWS_SNS_TOPIC_ARN semantic convention attribute for the following AWS resources: AWS SNS SDK v1 AWS SNS SDK v2 The topic ARN is extracted from both request and response objects, and this behavior is covered by unit tests. Tests Run: ./gradlew spotlessCheck ./gradlew instrumentation:check ./gradlew :smoke-tests:test All newly added tests pass, and no regressions were found. Backward Compatibility: This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
This PR adds the AWS_SNS_TOPIC_ARN semantic convention attribute for the following AWS resources:
AWS SNS SDK v1
AWS SNS SDK v2
The topic ARN is extracted from both request and response objects, and this behavior is covered by unit tests.
Tests Run:
./gradlew spotlessCheck
./gradlew instrumentation:check
./gradlew :smoke-tests:test
All newly added tests pass, and no regressions were found.
Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.