Skip to content

enhance & align jetty jmx metrics #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented Jun 19, 2025

  • rename and attempt to align existing jetty jmx metrics to semconv, this is a breaking change as it renames and modifies the metric attributes
  • remove the jetty.logging.LoggerCount metric for the number of registered loggers as it's probably not very relevant
  • integration test with jetty 9 to jetty 12
  • add support for jetty 12 with different metrics & metrics attributes due to jetty implementation details

The current implementation maps all the MBean parameters to metric attributes, and the main problem here is that we have a lot of "technical" attributes that do not provide any value to the end user, can cause high cardinality and are just artifacts of the underlying implementation.

I have opened #14070 to discuss the ways we could solve this issue.
I think progress on this PR will be blocked until we solve this issue first.

Update (1): ignoring technical MBean parameter is fine when there is only a single MBean instance, which is the case by default. We can however decide to avoid producing any potentially invalid metric by removing most of the gauge metrics.

Update (2): we decided in the 2025-06-26 SIG meeting to remove any problematic metric, we can always add them later if needed, or add a feature to handle them properly.
Also, most if not all of the impacted metrics are for Jetty 11 and earlier, which are EOL in Jetty documentation. Those metrics do not have an equivalent for Jetty 12 yet.

@SylvainJuge
Copy link
Contributor Author

following 2025-06-26 SIG meeting, jetty metrics have been simplified to only include the ones that are not susceptible to unpredictable aggregation (gauges with multiple mbean instances as documented in this other PR).

@SylvainJuge SylvainJuge marked this pull request as ready for review June 27, 2025 14:57
@SylvainJuge SylvainJuge requested a review from a team as a code owner June 27, 2025 14:57
@trask
Copy link
Member

trask commented Jun 28, 2025

cc @PeterF778 @robsunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants