-
Notifications
You must be signed in to change notification settings - Fork 969
enhance & align jetty jmx metrics #14067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SylvainJuge
wants to merge
21
commits into
open-telemetry:main
Choose a base branch
from
SylvainJuge:jmx-jetty
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into jmx-jetty
…nstrumentation into jmx-jetty
…nstrumentation into jmx-jetty
following 2025-06-26 SIG meeting, jetty metrics have been simplified to only include the ones that are not susceptible to unpredictable aggregation (gauges with multiple mbean instances as documented in this other PR). |
…nstrumentation into jmx-jetty
…nstrumentation into jmx-jetty
…nstrumentation into jmx-jetty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jetty.logging.LoggerCount
metric for the number of registered loggers as it's probably not very relevantThe current implementation maps all the MBean parameters to metric attributes, and the main problem here is that we have a lot of "technical" attributes that do not provide any value to the end user, can cause high cardinality and are just artifacts of the underlying implementation.I have opened #14070 to discuss the ways we could solve this issue.I think progress on this PR will be blocked until we solve this issue first.
Update (1): ignoring technical MBean parameter is fine when there is only a single MBean instance, which is the case by default. We can however decide to avoid producing any potentially invalid metric by removing most of the gauge metrics.
Update (2): we decided in the 2025-06-26 SIG meeting to remove any problematic metric, we can always add them later if needed, or add a feature to handle them properly.
Also, most if not all of the impacted metrics are for Jetty 11 and earlier, which are EOL in Jetty documentation. Those metrics do not have an equivalent for Jetty 12 yet.