Rework how we release to central #14146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Jun 27, 2025
| @@ -16,6 +20,12 @@ plugins { | |||
| id("org.graalvm.buildtools.native") apply false | |||
| } | |||
|
|
|||
| buildscript { | |||
| dependencies { | |||
| classpath("com.squareup.okhttp3:okhttp:4.12.0") | |||
There was a problem hiding this comment.
initially wanted to use jdk http client but doing the multipart upload there seemed too hard
laurit
commented
Jun 27, 2025
|
|
||
| var query = "?name=opentelemetry-java-instrumentation-$stableVersion" | ||
| // uncomment to automatically publish the release | ||
| // query += "&publishingType=AUTOMATIC" |
There was a problem hiding this comment.
Without this parameter we need to publish the uploaded bundled manually. After first successful release we can uncomment it.
zeitlinger
approved these changes
Jun 27, 2025
jaydeluca
approved these changes
Jun 27, 2025
trask
pushed a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last release with OSSRH Staging API didn't go well we need an alternative way for future releases. We could either adopt JReleaser or one of the plugins from https://central.sonatype.org/publish/publish-portal-gradle/#alternatives or build our own solution.
To publish to central we first publish to a local maven repository named
ReleaseRepousingpublishAllPublicationToReleaseRepoRepositorythen we zip that repository usinggenerateReleaseBundle(these 2 were tested when fixing the 2.17.0 release) and finally upload it withuploadReleaseBundle(this one is untested). We could test by failing the build at the end ofuploadReleaseBundleand check whether the uploaded bundle is valid in the publisher portal.