fix: text field validation for minLength: 1, required: false

[jcgsville]

Fixes #13113

How?

Does not rely on JS falseyness, instead explicitly checking for null & undefined

I'm not actually certain this is the approach we want to take. Some people might interpret "required" as not null, not-undefined and min length > 1 in the case of strings. If they do, this change to the behavior in the not-required case will break their expectations

[jessrynkar]

@jcgsville this all looks good - however your test needs to be updated, it has expect(result).toBe(true) which is the current behavior, after this change you will want it to be expect(result).toBe('validation:shorterThanMax').

[jcgsville]

Thanks @jessrynkar. Sorry for the noise, I just let the pipeline run the tests rather than get a full local setup. Fixing now

[jcgsville]

I think the failing CI step is unrelated to my change? It's a bundle size check, if I understand correctly. My change should not have affected bundle size. Gonna do a no-op commit to rerun CI

[jcgsville]

Not sure why that check is failing consistently. May need some help

[jessrynkar]

@jcgsville I think it's just flaky, I'm rerunning them now