Skip to content

executor: log error in the Close of joinv1 instead of returning it #62352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2025
Merged

executor: log error in the Close of joinv1 instead of returning it #62352

merged 3 commits into from
Jul 14, 2025
+15 −27

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #62351

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jul 10, 2025

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

windtalker
windtalker approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.7135%. Comparing base (af367b8) to head (0338474).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #62352        +/-   ##
================================================
+ Coverage   72.9428%   73.7135%   +0.7706%     
================================================
  Files          1752       1755         +3     
  Lines        484904     491375      +6471     
================================================
+ Hits         353703     362210      +8507     
+ Misses       109567     107536      -2031     
+ Partials      21634      21629         -5
Flag Coverage Δ
integration 42.7416% <55.5555%> (?)
unit 72.4310% <55.5555%> (+0.2330%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3374% <ø> (+0.0281%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zimulala
zimulala reviewed Jul 10, 2025
View reviewed changes
pkg/executor/test/issuetest/executor_issue_test.go Outdated
@@ -787,7 +787,7 @@ func TestIssue60923(t *testing.T) {
tk.MustExec("insert into t1 values (0, 10), (1, 10), (2, 10), (3, 10), (4, 10), (5, 10), (6, 10), (7, 10), (8, 10), (9, 10), (10, 10);")
tk.MustExec("insert into t2 values (0, 5), (0, 5), (1, 5), (2, 5), (2, 5), (3, 5), (4, 5), (5, 5), (5, 5), (6, 5), (7, 5), (8, 5), (8, 5), (9, 5), (9, 5), (10, 5);")

testfailpoint.Enable(t, "github.com/pingcap/tidb/pkg/executor/join/issue60923", "panic")
testfailpoint.Enable(t, "github.com/pingcap/tidb/pkg/executor/join/issue6", "panic")
Copy link
Contributor

@zimulala zimulala Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is issue6 a typo? If so, why does this test work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is issue6 a typo? If so, why does this test work?

typo, and ci shows this test fail.

@xzhangxian1008 xzhangxian1008 requested a review from zimulala July 14, 2025 05:35
windtalker
windtalker approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2025

@windtalker: Your lgtm message is repeated, so it is ignored.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 14, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-10 08:12:08.21017888 +0000 UTC m=+2160180.933357854: ☑️ agreed by windtalker.
  • 2025-07-14 06:33:01.626669099 +0000 UTC m=+2499834.349848104: ☑️ agreed by gengliqi.

@tiprow tiprow
Copy link

tiprow bot commented Jul 14, 2025

@xzhangxian1008: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 66db962 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit ea2ff4d into pingcap:master Jul 14, 2025
25 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-60926-1 branch July 15, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@gengliqi gengliqi gengliqi approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log error in the Close of joinv1 instead of returning it
4 participants
@xzhangxian1008 @windtalker @zimulala @gengliqi