Skip to content
This repository was archived by the owner on Mar 19, 2025. It is now read-only.

s390x: Create new VPC for each job #213

Closed
wants to merge 1 commit into from

Conversation

prabhav-thali
Copy link
Contributor

This enables us to fetch the name from boskos and use it to create new vpc. Rather than using existing vpc and subnet, Create a new vpc for every job.

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prabhav-thali
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2025
@ppc64le-cloud-bot
Copy link
Contributor

Hi @prabhav-thali. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2025
@Prajyot-Parab
Copy link

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@mkumatag
Copy link
Member

@prabhav-thali please submit the change to https://github.com/kubernetes-sigs/provider-ibmcloud-test-infra going forward

@mkumatag mkumatag closed this Mar 13, 2025
@prabhav-thali
Copy link
Contributor Author

@mkumatag Sure, will raise the PR to provider-ibmcloud-test-infra

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants