Clean up backend indexing some more #10376
Open
+93
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
May 30, 2025
| for k, v in self._variables.items(): | ||
| v = v.copy(deep=True) | ||
| res[k] = v | ||
| v._data = indexing.LazilyIndexedArray(v._data) |
There was a problem hiding this comment.
Harmonizes this test backend with all the other backends
dcherian
commented
May 30, 2025
| @@ -190,7 +190,7 @@ def ds(self): | |||
| def open_store_variable(self, name, var): | |||
| return Variable( | |||
| var.dimensions, | |||
| ScipyArrayWrapper(name, self), | |||
| indexing.LazilyIndexedArray(ScipyArrayWrapper(name, self)), | |||
There was a problem hiding this comment.
harmonized with the other backends
dcherian
commented
May 30, 2025
dcherian
commented
May 30, 2025
dcherian
force-pushed
the
more-duck-array
branch
from
8564e74 to
11fec41
Compare
dcherian
force-pushed
the
more-duck-array
branch
from
4f01391 to
1e40376
Compare
github-actions
bot
added
CI
dcherian
force-pushed
the
more-duck-array
branch
from
123d5e2 to
275330d
Compare
dcherian
force-pushed
the
more-duck-array
branch
from
275330d to
0ed11f5
Compare
5 tasks
TomNicholas
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Awesome @dcherian !
The docs failure looks like it might be catching something real though
Extension error:
--
2043 | Cell raised uncaught exception:
2044 | �[31mAttributeError�[39m�[31m:�[39m '_ElementwiseFunctionArray' object has no attribute 'transpose'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonizes some internal code paths to make the async work less painful (#10327).
Closes #8909
Closes #8921
I added a new CI with only scipy as the optional dependency to prevent regressing on #8909
I'll add comments for the remaining changes