Skip to content

Add users.policies_acknowledged_at #5530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

segiddins
Copy link
Member

So we can track when users last acked the policies, and prompt them to do so when we introduce/update them

Signed-off-by: Samuel Giddins segiddins@segiddins.me

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (c578757) to head (4269877).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5530   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         460      460           
  Lines        9552     9559    +7     
=======================================
+ Hits         9280     9287    +7     
  Misses        272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@segiddins segiddins force-pushed the segiddins/add-users.policies_acknowledged_at branch from 1a7bc4d to e7114fa Compare March 12, 2025 18:49
@colby-swandale colby-swandale self-assigned this Mar 19, 2025
@simi simi force-pushed the segiddins/add-users.policies_acknowledged_at branch from e7114fa to b08b505 Compare March 21, 2025 21:22
So we can track when users last acked the policies, and prompt them to do so when we introduce/update them

Signed-off-by: Samuel Giddins <segiddins@segiddins.me>
@colby-swandale colby-swandale force-pushed the segiddins/add-users.policies_acknowledged_at branch from b08b505 to 5e23c83 Compare June 30, 2025 03:28
@simi
Copy link
Member

simi commented Jun 30, 2025

@mghaught would you mind to update what's the last take on this? How this approval is going to be collected?

@colby-swandale
Copy link
Member

colby-swandale commented Jun 30, 2025

@simi as per the email:

we will display a banner on RubyGems.org prompting users to review and accept the new policies.

I'm going to add this functionality into a separate PR

@colby-swandale colby-swandale merged commit d8417a1 into master Jun 30, 2025
21 checks passed
@colby-swandale colby-swandale deleted the segiddins/add-users.policies_acknowledged_at branch June 30, 2025 10:50
@github-project-automation github-project-automation bot moved this from Ready to Merged in RubyGems.org Pull Requests Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants