Nightly releases are published even with no changes

[brendankenny]

The cron job is intended to only publish a nightly version to npm when there's been a change in the last day, but it's still plugging along and publishing a nightly version every day.

I haven't actually tried debugging, but just reading it, it might just be publish needs a needs: check_date line to tie them together?

lighthouse/.github/workflows/publish.yml

Lines 22 to 28 in 1f06b0f

	publish:
	# Prevent scheduled job from running if...
	# 1) this is a fork
	# 2) there has not been a change in the last day
	if: |
	github.event_name != 'schedule' ||
	(github.repository == 'GoogleChrome/lighthouse' && ${{ needs.check_date.outputs.should_run != 'false' }})

[connorjclark]

100% we need needs: check_date there. Nice catch.

[brendankenny]

heh, I guess not sufficient :/