-
Notifications
You must be signed in to change notification settings - Fork 9.5k
core(plugins): support scoped npm packages #16550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks! Will need a couple things first before landing this:
|
done |
Linting is failing. I tried pushing to the forked branch but for some reason GitHub is not allowing me. Here is what I wanted to patch in.
|
okay, should be good now, i applied your patch |
Thanks! |
Summary
currently we can't use plugins that are namespaced, e.g. @myorg/lighthouse-plugin-blabla
im simply splitting on / and checking if the second part starts with the correct prefix.
Related Issues/PRs