chore: core PR 6066 test drive #34064
Draft
+113
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
4 tasks
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [0979a93]
UI Startup Metrics (1232 ± 64 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 7 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 26 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2323 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1751 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1744 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 269 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 18 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1740 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2779 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2082 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2077 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 409 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 64 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2065 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1726 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 207 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 24 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1735 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1494 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1494 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 117 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1473 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2105 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1723 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1723 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 306 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 19 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1696 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 815ms | Sum of p95 exceeds: 1341.8ms Sum of all benchmark exceeds: 2156.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
Builds ready [2b43095]
UI Startup Metrics (1253 ± 62 ms)
Benchmark value 1073 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1369 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2255 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 254 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2696 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 42 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1992 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 18 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1813 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 331 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 77 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 56 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 82 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1722 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1484 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 113 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1464 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2193 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1772 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1771 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 295 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 53 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 42 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 13 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1738 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 54 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 598ms | Sum of p95 exceeds: 1542.8ms Sum of all benchmark exceeds: 2140.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +4 -4)
📜 @MetaMask/policy-reviewers (4 files, +4 -4)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +4 -4)
|
Builds ready [13bb173]
UI Startup Metrics (1226 ± 75 ms)
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1366 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 20 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2281 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 281 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2745 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2012 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 406 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2000 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1456 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1252 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1252 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 22 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 19 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1802 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 275 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 112 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 171 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1669 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1439 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 19 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1418 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2061 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1694 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1694 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 297 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 20 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1677 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 508ms | Sum of p95 exceeds: 1323.8ms Sum of all benchmark exceeds: 1831.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR can be used a reference on how to implement the breaking changes introduced by MetaMask/core#6066 for:
TokenDetectionControllerMultichainNetworkControllerTransactionControllerChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist