fix: network form #34070
Open
fix: network form #34070
+150
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux (8 files, +89 -20)
|
Builds ready [fcc9153]
UI Startup Metrics (1171 ± 63 ms)
Benchmark value 2307 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1756 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1750 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 246 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1744 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2705 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2063 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2047 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 407 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2005 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1702 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 345 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 78 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1633 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1397 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1397 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1375 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2029 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1695 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1695 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 278 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1671 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 41 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 356ms | Sum of p95 exceeds: 989ms Sum of all benchmark exceeds: 1345ms |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [ef5f4ff]
UI Startup Metrics (1197 ± 65 ms)
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2304 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1758 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1751 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 238 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1748 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2714 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2052 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2035 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 409 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2023 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1418 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1698 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 315 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1676 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 18 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1419 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2047 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1701 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1701 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 296 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 55 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 1675 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 30 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 560ms | Sum of p95 exceeds: 1031ms Sum of all benchmark exceeds: 1591ms |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
salimtb
force-pushed
the
fix/fix-network-form
branch
from
a94385e to
e56a3c1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
salimtb
force-pushed
the
fix/fix-network-form
branch
from
e56a3c1 to
befbbcc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [befbbcc]
UI Startup Metrics (1200 ± 76 ms)
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 28 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2288 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1718 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1711 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 275 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 1708 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2700 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2015 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 71 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 2004 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1411 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1677 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 316 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 32 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 70 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1656 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1410 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 29 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1387 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2129 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1749 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1749 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 315 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 1724 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 344ms | Sum of p95 exceeds: 1166ms Sum of all benchmark exceeds: 1510ms |
kikiki1378
approved these changes
Jul 5, 2025
Prithpal-Sooriya
previously approved these changes
Jul 8, 2025
salimtb
force-pushed
the
fix/fix-network-form
branch
from
befbbcc to
4a7db49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [d87f04c]
UI Startup Metrics (1232 ± 54 ms)
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2300 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1739 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1733 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 255 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1729 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2746 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2041 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2018 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 401 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 41 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2005 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 8 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1694 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 308 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 71 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 40 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 49 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 38 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1697 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 114 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1426 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2176 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1811 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1811 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 357 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 72 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1790 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 569ms | Sum of p95 exceeds: 1602.8ms Sum of all benchmark exceeds: 2171.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [cad05bd]
UI Startup Metrics (1223 ± 73 ms)
Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 20 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2259 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 272 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2681 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 409 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 36 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1983 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1480 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1268 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1268 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1247 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 22 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1805 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 235 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 16 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 150 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1711 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1447 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1447 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 112 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1426 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2196 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1803 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 333 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 71 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1784 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 630ms | Sum of p95 exceeds: 1605.8ms Sum of all benchmark exceeds: 2235.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [082ca0c]
UI Startup Metrics (1272 ± 68 ms)
Benchmark value 1091 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1083 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1415 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1203 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1194 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2200 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 275 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2631 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1498 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1291 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1291 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1269 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 21 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1793 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 261 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 26 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 177 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1713 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1455 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1455 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 61 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1435 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2166 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1817 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1816 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 316 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1791 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 29 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 766ms | Sum of p95 exceeds: 1655.8ms Sum of all benchmark exceeds: 2421.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Prithpal-Sooriya
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Bug: Modal Fails When Network Config Missing
Runtime errors occur in the SelectRpcUrlModal component when networkConfigurationToUse is undefined. This happens if the optional networkConfiguration prop is not supplied AND the chainId obtained from location.state is either undefined or does not correspond to an existing network in evmNetworks. Subsequent attempts to access properties like chainId, name, and rpcEndpoints on the undefined networkConfigurationToUse then cause "Cannot read properties of undefined" errors.
ui/components/multichain/network-list-menu/select-rpc-url-modal/select-rpc-url-modal.tsx#L35-L47
Bug: Network Removal Bug: Inconsistent ID Handling
The onNetworkRemoved method, triggered only for EVM network removals, has two issues: it redundantly checks isCaipChainId(networkId) (always false for a Hex ID), and its conditional deletion logic for enabledNetworkMap (using Hex for EIP155 and CAIP for others) results in the non-EIP155 deletion path being unreachable, preventing non-EVM networks from being removed.
app/scripts/controllers/network-order.ts#L187-L204
metamask-extension/app/scripts/controllers/network-order.ts
Lines 187 to 204 in 93c30ba
Bug: Incorrect Callback Type in Modal
Type mismatch in SelectRpcUrlModal: the onNetworkChange prop expects (chainId: CaipChainId, networkClientId: string) => void, but the handleClose function (() => void) is passed, leading to incorrect arguments or runtime errors when the callback is invoked.
ui/components/multichain/network-manager/network-manager.tsx#L221-L222
Bug: Selector Function Used Incorrectly
isGlobalNetworkSelectorRemoved is a selector function that is imported and used directly as a boolean condition. Selectors must be called with the Redux state as an argument to return their actual value. Because it's a function object, the condition if (isGlobalNetworkSelectorRemoved) always evaluates to true, rendering the conditional logic ineffective. It should be called with state or passed as a prop from a connected component.
ui/components/app/loading-network-screen/loading-network-screen.component.js#L125-L130
Was this report helpful? Give feedback by reacting with 👍 or 👎
Builds ready [93c30ba]
UI Startup Metrics (1270 ± 59 ms)
Benchmark value 1095 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1088 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 835 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1371 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 21 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2204 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 252 exceeds gate value 235 for chrome webpack home mean firstReactRender Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2698 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 404 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1986 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1412 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 9 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1726 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 392 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 46 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 54 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1662 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1416 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1416 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 60 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1397 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2129 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1797 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1797 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 68 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1770 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 360ms | Sum of p95 exceeds: 1461.8ms Sum of all benchmark exceeds: 1821.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
darkwing
reviewed
Jul 9, 2025
| @@ -76,7 +81,13 @@ const NetworkManagerRouter = () => { | |||
| ], | |||
| defaultRpcEndpointIndex: networkFormState.rpcUrls.rpcEndpoints.length, | |||
| }); | |||
| history.push('/add'); | |||
|
|
|||
| // TODO: Handle edit case | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues:
Changelog
CHANGELOG entry:
Related issues
Fixes: #32085 #34057
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist