fix: stops generating invalid bridge quotes when no dest addr

[ghgoodreau]

…d required

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (1 files, +11 -3)

• 📁 ui/
  • 📁 pages/
    • 📁 bridge/
      • 📁 prepare/
        • 📄 prepare-bridge-page.tsx +11 -3

[metamaskbot]

Builds ready [7b351ec]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1281 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1281	1130	1559	72	1333	1378
			load	1097	960	1313	62	1142	1187
			domContentLoaded	1089	955	1300	62	1136	1178
			domInteractive	19	15	46	7	18	41
			firstPaint	737	87	1235	435	1124	1181
			backgroundConnect	8	4	33	4	9	16
			firstReactRender	23	16	59	6	24	37
			getState	16	6	47	8	22	33
			initialActions	4	0	21	5	7	17
			loadScripts	833	709	1031	59	874	921
			setupStore	8	4	29	4	9	15
	Webpack	Home	uiStartup	2207	1721	2829	206	2320	2629
			load	1663	1303	2103	161	1755	1984
			domContentLoaded	1656	1299	2091	160	1751	1963
			domInteractive	18	13	80	14	15	59
			firstPaint	153	63	387	63	168	288
			backgroundConnect	25	10	272	26	27	46
			firstReactRender	264	90	423	123	385	402
			getState	13	4	42	7	16	33
			initialActions	14	3	305	39	9	31
			loadScripts	1651	1298	2079	156	1749	1922
			setupStore	19	7	309	30	18	28
Firefox	Browserify	Home	uiStartup	1459	1284	1956	139	1528	1778
			load	1272	1109	1527	100	1329	1496
			domContentLoaded	1272	1109	1527	100	1329	1495
			domInteractive	126	34	499	78	127	333
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	14	135	17	25	64
			firstReactRender	27	22	53	5	27	34
			getState	15	5	267	32	10	39
			initialActions	4	0	31	6	3	19
			loadScripts	1251	1091	1513	99	1306	1453
			setupStore	14	4	194	28	10	40
	Webpack	Home	uiStartup	1749	1454	3604	264	1822	2180
			load	1490	1248	1856	143	1591	1741
			domContentLoaded	1489	1247	1856	143	1591	1740
			domInteractive	110	36	362	58	106	288
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	52	7	28	43
			firstReactRender	43	32	61	5	46	51
			getState	30	6	1677	166	12	32
			initialActions	8	0	224	31	6	15
			loadScripts	1470	1223	1829	141	1568	1701
			setupStore	15	5	236	33	10	37

Benchmark value 1281 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1098 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1090 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 833 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1378 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 2207 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 265 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 14 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 2629 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 31 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 1460 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1273 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1272 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 126 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1251 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1778 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 333 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 40 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1750 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1490 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1490 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 31 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1470 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 16 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2180 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1741 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1740 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 288 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1701 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 842ms | Sum of p95 exceeds: 1197.8ms
Sum of all benchmark exceeds: 2039.8ms

Bundle size diffs [🚀 Bundle size reduced!]

• background: 17.1 KiB (0.32%)
• ui: 15.7 KiB (0.21%)
• common: -55.28 KiB (-0.64%)