-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
🔥 Removed AMP app connection to core app, Added redirectAmpUrls middleware #23981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ghost/core/core/server/web/shared/middleware/sanitize-amp-urls.js
Outdated
Show resolved
Hide resolved
ghost/core/test/unit/frontend/helpers/__snapshots__/ghost_head.test.js.snap
Outdated
Show resolved
Hide resolved
4b4829f
to
fe5a6b0
Compare
7f2030f
to
c3ef316
Compare
ghost/core/test/unit/frontend/helpers/__snapshots__/ghost_head.test.js.snap
Show resolved
Hide resolved
ghost/core/core/server/web/shared/middleware/sanitize-amp-urls.js
Outdated
Show resolved
Hide resolved
ref #23924 closes https://linear.app/ghost/issue/PROD-2115/unload-amp-app-from-express - First step for removing AMP support in Ghost 6.0 is no longer loading the AMP app - The AMP app was responsible for redirecting /amp routes, so sanitizeAmpUrls was added as a middleware to take over that task - sanitizeAmpUrls was added as part of the pretty-urls middleware sequence
b330e86
to
89ca4d7
Compare
…eware (#23981) ref #23924 closes https://linear.app/ghost/issue/PROD-2115/unload-amp-app-from-express - First step for removing AMP support in Ghost 6.0 is no longer loading the AMP app - The AMP app was responsible for redirecting /amp routes, so redirectAmpUrls was added as a middleware to take over that task - this was added as part of the pretty-urls middleware sequence
ref #23924
closes https://linear.app/ghost/issue/PROD-2115/unload-amp-app-from-express