Skip to content

Get rid of use of PAT #348

Open
Open
@jepler

Description

@jepler

The following jobs use secrets.ADABOT_GITHUB_ACCESS_TOKEN which is a classic personal authentication token:

.github/workflows/bundle_cron.yml:        ADABOT_GITHUB_ACCESS_TOKEN: ${{ secrets.ADABOT_GITHUB_ACCESS_TOKEN }}
.github/workflows/learn_cron.yml:        token: ${{ secrets.ADABOT_GITHUB_ACCESS_TOKEN }}
.github/workflows/reports_cron.yml:      ADABOT_GITHUB_ACCESS_TOKEN: ${{ secrets.ADABOT_GITHUB_ACCESS_TOKEN }}
.github/workflows/test.yml:        ADABOT_GITHUB_ACCESS_TOKEN: ${{ secrets.ADABOT_GITHUB_ACCESS_TOKEN }}

When use of classic PATs was disabled, at least "learn_cron" and "bundle_cron" failed.

classic PATs have now been re-enabled at the repo level and the steps seem to succeed now instead of failing. However, we should do something about the use of classic PATs in the long term.

For learn_cron and bundle_cron, one possibility might be to move those items to the cron of learn / bundle, where they will automatically have a token that lets them push to the same repo where the action is running.

attn @kattni please add any info I'm missing or make any corrections, I'm operating on incomplete knowledge here (as we all may be)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions