docs: More restrictive permissions #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
removed the checkout, not needed |
zMynxx
commented
Mar 25, 2025
changed back to using secrets.GITHUB_TOKEN as requested by owner
zMynxx
changed the title
zMynxx
changed the title
zMynxx
changed the title
amannn
approved these changes
Mar 25, 2025
| @@ -118,7 +118,7 @@ module.exports = async function run() { | |||
| }); | |||
| } catch (error) { | |||
| throw new Error( | |||
| `Pull request has only one commit and it's not semantic; this may lead to a non-semantic commit in the base branch (see https://github.com/community/community/discussions/16271). Amend the commit message to match the pull request title, or add another commit.` | |||
| `Pull request has only one commit and it's not semantic; this may lead to a non-semantic commit in the base branch (see https://github.com/community/community/discussions/16271 ). Amend the commit message to match the pull request title, or add another commit.` | |||
amannn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the GitHub Actions workflows to use permissions scope at the job-level (dedicated) instead of workflow level (shared) in case anyone copy-paste and adds some more jobs to the flow.
Updated the url provided in case of a non-compliant commit message, to have it resolved properly.
Type of change
Changes required
How Has This Been Tested?
Permissions block,
-o pipefailflag, urlfix:ci: validation zMynxx/action-semantic-pull-request#3
Invalid url fix:
before (invalid link):
https://github.com/zMynxx/action-semantic-pull-request/actions/runs/14055509974/job/39354003059#step:6:9
after (valid):
https://github.com/zMynxx/action-semantic-pull-request/actions/runs/14055844489/job/39355025376#step:6:9