Skip to content

docs: Remove synchronize trigger #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

docs: Remove synchronize trigger #281

merged 1 commit into from
Apr 28, 2025

Conversation

jguddas
Copy link
Contributor

@jguddas jguddas commented Apr 26, 2025

I don't think this trigger is necessary and needlessly increases cost.

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think you're right!

Can you modify the workflows in .github to remove this trigger when used in combination with action-semantic-pull-request?

@jguddas
Copy link
Contributor Author

jguddas commented Apr 27, 2025

Can you modify the workflows in .github to remove this trigger when used in combination with action-semantic-pull-request?

I would keep it, since you could be pushing changes to ./action.yml and then you want to see them take effect.

Same issue I guess for people who edit the settings of the workflow.

Example:

  1. I create a PR.
  2. I add new type to my .github/workflows/lint-pr-title.yml and push that change to my existing PR.
  3. Workflow does not automatically rerun since there is no trigger.

I'm still of the opinion we should remove the trigger from the docs, we are just burning money 💸💸💸

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, let's leave it like this then.

I agree, for pretty much every case it's not needed to run on synchronize.

@amannn amannn changed the title docs: removes synchronize trigger docs: Remove synchronize trigger Apr 28, 2025
@amannn amannn merged commit 3352882 into amannn:main Apr 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants