Keep test worker alive until explicitly freed #3391
Merged
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
force-pushed
the
fix-failing-with-remaining-tests-on-windows
branch
from
e903735 to
1dbae79
Compare
This change ensures that all messages from the worker are received by the main process before the worker exits. It solves issues on Windows that are occurring with Node.js v20 and later when `workerThreads: false` is set in the AVA configuration. Fixes: avajs#3390
matz3
force-pushed
the
fix-failing-with-remaining-tests-on-windows
branch
from
1dbae79 to
68d14e4
Compare
Whether the worker exits depends on whether user code is keeping the event loop busy. 'Freed' is a better term.
novemberborn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all messages from the worker are received by the main process before the worker exits.
It solves issues on Windows that are occurring with Node.js v20 and later when
workerThreads: falseis set in the AVA configuration.Fixes: #3390