Classical album separation based on compose, driving me nuts :)

[mannp]

Hi all

I am following on and trying to get things to work from this thread, but I am getting errors, and I am not sure why.

Initial discussion and working config

I am using the nix home manager module, so the definition is different but the end result in the config.yaml is supposed to be the same (or interpreted the same);

          albumcomposers = ''
            c_set = set()
            for item in items:
                c_set.update(item.composer.split("; "))
            return c_set
          '';
          multicomposer = ''1 if len(albumcomposers) > 0 else 0'';  

which translate to this config.yaml snippet;

item_fields:
  albumcomposers: "c_set = set()\nfor item in items:\n    c_set.update(item.composer.split(\"\
    ; \"))\nreturn c_set\n"
  multicomposer: '1 if len(albumcomposers) > 0 else 0 '

  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beets/library.py", line 478, in _get
    return self._get_formatted(self.model, key)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beets/dbcore/db.py", line 124, in _get_formatted
    value = model._type(key).format(model.get(key))
                                    ^^^^^^^^^^^^^^
  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beets/library.py", line 773, in get
    return self._get(key, default, raise_=with_album)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beets/dbcore/db.py", line 449, in _get
    return getters[key](self)
           ^^^^^^^^^^^^^^^^^^
  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beetsplug/inline.py", line 124, in _func_func
    raise InlineError(python_code, exc)
beetsplug.inline.InlineError: error in inline path field code:
c_set = set()
for item in items:
    c_set.update(item.composer.split("; "))
return c_set

NameError: name 'items' is not defined

I have tried editing the resulting config.yaml and pasting exactly the following and I get a different error :-(

  albumcomposers: |
      # sets do not allow duplicates
      c_set = set()
      for item in items:
          c_set.update(item.composer.split("; "))
      return c_set
  multicomposer: 1 if len(albumcomposers) > 0 else 0

  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beetsplug/inline.py", line 112, in _expr_func
    raise InlineError(python_code, exc)
beetsplug.inline.InlineError: error in inline path field code:
1 if len(albumcomposers) > 0 else 0
NameError: name 'albumcomposers' is not defined

I am not sure why inline is complaining as a python noob.

Any pointers as to the config.yaml result or the subsequent error would be a great help.

Thanks.

[DjSlash]

You are putting the snippets in the wrong place, namely under item_fields. That should be album_fields. Please see the inline plugin documentation.

[mannp]

Thanks, yes I read it before, with some ambiguity and confusion.

Beets plugins usually have 1 definition block, while this appears to have two.

Items are item templates in the item_fields but only for tracks (The Python code has all of a track’s fields in scope) so why is it not called track_fields instead of item_fields...inconsistent and confusing, as both item_fields and album_fields have item fields.

While album_fields also have items, but not related to item_fields definition block...confusing.

inline:
   track_fields:
   album_fields

Anyway, thanks for pointing out the error of my ways :)

[mannp]

There is no error I can see, but I assume that albumcomposers doesn't get set due some error in interpreting its python code?

Traceback (most recent call last):
  File "/nix/store/j58mkr2cl4821xckvyxl90mjilj4wrpi-beets-2.3.1/lib/python3.12/site-packages/beetsplug/inline.py", line 110, in _expr_func
    return eval(code, values)
           ^^^^^^^^^^^^^^^^^^
  File "inline", line 1, in <module>
NameError: name 'albumcomposers' is not defined

album_fields:
  albumcomposers: "c_set = set()\nfor item in items:\n    c_set.update(item.composer.split(\"\
    ; \"))\nreturn c_set\n"
  multicomposer: 1 if len(albumcomposers) > 0 else 0

[halloleo]

The problem is that each field albumcomposers and multicomposer are evaluate in separate global scopes.

I had the same problem and solved it for me by extending the inline plugin: Have a look at beets-inlineplus -- maybe it works for you too. If you decide to try inlineplus, please leave me feedback -- I'm sure I didn't cover all corner cases...