Support removing wildcard imports via removeWildcardImports step

[iddeepak]

I have just opened a PR to help us say “goodbye” to those sneaky wildcard imports (like import java.util.*;) whenever Spotless tidies up our Java files. Wildcard imports can make it hard to see exactly which classes you’re relying on, so this change introduces a new step in the Spotless plugin that:

Spots any import foo.*; lines in your source

Removes them outright (so your IDE or build tools can regenerate only the exact imports you need)

• Closes Unused wild card imports are not removed #240.
• Closes Add remove wildcards imports when formating and ordering imports. #649.
• Closes spotless maven eclipse jdt - How to block import star (*) wildcard? #832.

[Pankraz76]

awesome, thanks.

[Goooler]

LGTM! Would you mind adding a test for the Gradle plugin?

[Pankraz76]

could migrate the .editorconfig as well dedicated, assuming spot it applied on itself, like checkstyle does impose all checks on itself, too.

spotless/.editorconfig

Line 20 in 2cc8c04

ij_java_class_count_to_use_import_on_demand = 999

[iddeepak]

could migrate the .editorconfig as well dedicated, assuming spot it applied on itself, like checkstyle does impose all checks on itself, too.

spotless/.editorconfig

Line 20 in 2cc8c04

ij_java_class_count_to_use_import_on_demand = 999

you mean spot checks on .editorconfig something like this

format("editorconfig") { target "spotless/.editorconfig" editorConfig() }
@Pankraz76

[Pankraz76]

No, sorry—I meant we could remove this config, assuming it's not needed anymore, as Spot will prevent it now. But keeping it wouldn't hurt, as it still helps to avoid potential issues.

If auto-fix were possible, the config would still help prevent problems before fixing them, in the first place, but it wouldn't be strictly necessary anymore.

The next version will go further and deliver actual imports to fully automate this.

A win for the project. Thanks for the good craftsmanship!

[iddeepak]

No, sorry—I meant we could remove this config, assuming it's not needed anymore, as Spot will prevent it now. But keeping it wouldn't hurt, as it still helps to avoid potential issues.

If auto-fix were possible, the config would still help prevent problems before fixing them, in the first place, but it wouldn't be strictly necessary anymore.

The next version will go further and deliver actual imports to fully automate this.

A win for the project. Thanks for the good craftsmanship!

Ohh no my bad, I misunderstood it. Now it makes sense. Lets keep that setting in place as an extra safety as of now. Without it, IntelliJ’s default of 5 would collapse to a wildcard on the 6th import, then Spotless would strip that wildcard and force everyone to re-import.

[Goooler]

I meant we could remove this config, assuming it's not needed anymore, as Spot will prevent it now.

It could be honored by the IDEA side.

[Pankraz76]

Thanks.

[Pankraz76]

idea on removeObsoletes().

[Pankraz76]

removeObsoletes()
removeObsoleteInit()
removeObsoleteInitializations()

• https://github.com/diffplug/spotless/pull/2520/files#r2163362170