Disable ScrollTimeline in Safari #33499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: fc41c24...258f492 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
commented
Jun 10, 2025
| const supportsScrollTimeline = | ||
| typeof ScrollTimeline === 'function' && | ||
| (ua.indexOf('Safari') === -1 || | ||
| (ua.indexOf('iPhone') === -1 && ua.indexOf('iPad') === -1)); |
There was a problem hiding this comment.
Instead of special casing iOS we might be able to deopt to the polyfill only if a touch event has happened before we start.
sebmarkbage
force-pushed
the
disablesafariscrolltimeline
branch
6 times, most recently
from
79d5399 to
0923474
Compare
jackpope
approved these changes
Jul 1, 2025
|
Good catch disabling ScrollTimeline for Safari. |
sebmarkbage
force-pushed
the
disablesafariscrolltimeline
branch
from
0923474 to
258f492
Compare
This was referenced Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #33501.
This disables the use of ScrollTimeline when detected in Safari in the recommended SwipeRecognizer approach. I'm instead using a polyfill using touch events on iOS.
Safari seems set to release ScrollTimeline soon. Unfortunately it's not really what you'd expect.
First of all, it's not running in sync with the scroll which is kind of its main point. Instead, it is running at 60fps and out of sync with the scroll just like JS. In fact, it is worse than JS because with JS you can at least spawn CSS animations that run at 120fps. So our polyfill can respond to touches at 60fps while gesturing and then run at 120fps upon release. That's better than with ScrollTimeline.
Second, there's a bug which interrupts scrolling if you start a ViewTransition when the element is being removed as part of that. The element can still respond to touches so in a polyfill this isn't an issue. But it essentially makes it useless to use ScrollTimeline with swipe-away gestures.
So we're better off in every scenario by not using it.
The UA detection is a bit unfortunate. Not sure if there's something more specific but we also had to do a UA detection for Chrome for View Transitions. Those are the only two we have in all of React.