-
-
Notifications
You must be signed in to change notification settings - Fork 492
Open
Description
Are you submitting a bug report or a feature request?
bug report
What is the current behavior?
When using FormSpy
, the onChange
is called during rendering, and throws an error if you use setState
.
<FormSpy
subscription={{ values: true }}
onChange={change => {
// fired during rendering, calling a `useState` setter fails
setValues(change.values);
}}
/>
Warning: Cannot update a component (`App`) while rendering a different component (`FormSpy`). To locate the bad setState() call inside `FormSpy`, follow the stack trace as described in https://fb.me/setstate-in-render
in FormSpy (at App.js:23)
in form (at App.js:13)
in ReactFinalForm (at App.js:10)
in App (at src/index.js:9)
in StrictMode (at src/index.js:8)
What is the expected behavior?
No error.
Sandbox Link
https://codesandbox.io/s/react-final-form-formspy-hltnv?file=/src/App.js
What's your environment?
"final-form": "4.20.0",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-final-form": "6.5.0",
Other information
The issue seems to be that onChange
in the useFormState
is called in the useState
init function, which means during rendering:
react-final-form/src/useFormState.js
Line 26 in 464f1c7
onChange(initialState) |
This is part of a range of error messages introduced in react 16.13, and related to an existing issue (#751)
A workaround would be to put any setState
on the onChange
in a setTimeout(... ,0)
, but this feels like a hack, and not clear to new users.
Emad-Emami, CyrilSiman, kopax, delyanr, judge-dread and 18 morekopax and dvenediktova
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
kopax commentedon Jul 6, 2020
I am trying to read outside of the form the state saved in Redux and I got the same warning :
Related issue: #828
Is there a workaround or am I stuck with it?
muyiwaoyeniyi commentedon Jul 29, 2020
@erikras Please any help on this? While the changes you published to #751 seem to work, I don't think it covers setting state inside the onChange function in a FormSpy.
Thanks.
szankrisz commentedon Aug 7, 2020
The issue still persists with
react-final-form@6.5.1
andfinal-form@4.20.1
with react version16.13.1
. Here's what I've found after digging through the (compiled) library source:useField()
is invoked internally by thereact-final-form
library from within theField
component.useState()
hook. This parametrizes the internalregister()
function with atrue
second argument which is thesilent
flag. All is fine at this point.final-form
goes into a validation loop. I see in the stack trace that it invokesrunValidation()
which in turn leads tonotifyFieldListeners()
and then tonotifySubscribers()
on each field. This actually brings the code path back toreact-final-form
, into theuseEffect()
call inside of which the field is registered again but this time without thesilent
flag.I think the following happens: from the aspect of one particular field, registration indeed happens properly (first with the silent and then without the silent flag) but other fields could have completed this cycle already. So, when a field gets initialized it runs into the validation loop, causing the
setState()
call to take place inside other fields, thereby violating the rule.I have no suggestion at this point as to how it could be solved though.
floriangosse commentedon Feb 16, 2021
Does someone already have a solution or workaround for that problem?
ignatevdev commentedon Feb 25, 2021
In my case this error was caused by a mutator, which was called on every
FormSpy
render.I've solved this problem by wrapping the mutator call inside a
useLayoutEffect
and now everything works like before.cordial commentedon Mar 22, 2021
Does anyone have an example solution to this?
theZappr commentedon Mar 28, 2021
Hi all, I have been battling this issue while migrating from Redux-Form to React-Final-Form. Redux-Form has isDirty() in its API so I could easily get the state of a Form and use it in another (external) component. The only similar thing I can find for Final Form is FormSpy ( if not please let me know! ). In the end I had to give up and push the "dirty" flag into redux (in effect, rolling my own isDirty() for final-form) : which is when I bumped into the issue you are talking about here.
So far the only way I can get rid of the Warning is by wrapping the redux
dispatch
call in a cheekysetTimeout(,0)
. Hacky, stochastic, but it is working at least. Defo not a solution long term but thought I'd share :)igorpupkinable commentedon Oct 6, 2021
I am experiencing the same issue in our project.
I can help with investigation and report error details if needed.
mzehir commentedon Nov 4, 2021
@ThaNarie I hope you get rid of the error when you write it like this. this is how i solved it
<FormSpy
subscription={{ values: true,modified: true, }}
onChange={change => {
// fired during rendering, calling a
useState
setter failsif(Object.keys(state.modified).length > 0){
setValues(change.values);}
}}
/>
osya commentedon Jan 24, 2022
Could you please give an example?
vitbokisch commentedon Feb 25, 2022
Seems like one of the solutions can be creating your own
Spy
component in such a case, e.g. simple implementation could look like this:KienHui commentedon Apr 8, 2022
Little react hook: don't have a real onChange handler until after the first render is called.
fbolcic commentedon Aug 1, 2022
Hi guys,
Is there any fix for this issue on the horizon? We are experiencing the same error; Although, our stack involves slightly more moving parts so it is difficult to diagnose correctly where the issue arises:
react-final-form: ˆ6.5.7
react-final-form-arrays: ˆ3.1.3
@dnd-kit/sortable: 7.0.0
Also various ui component libraries.
As far as I understood, the issue is caused by
final-form
setting state while rerendering?Are there any news from the lib maintainer?
8 remaining items