Skip to content

coercions during alternative match leads to unexpected results #2579

@nlundquist

Description

@nlundquist

Support plan

  • is this issue currently blocking your project? (yes/no): yes
  • is this issue affecting a production system? (yes/no): yes

Context

  • node version: 14
  • module version with issue: 17.x
  • last module version without issue: n/a
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): standalone
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

Coercions occurring during an alternative match do not take precedence over the uncoerced values during the subschema response value merging, resulting in uncoerced properties overwriting coerced ones.

// coercion works as expected when not inside `alternatives`
joi.object({ org_id: joi.number().required() }).unknown().validate({ org_id: '5', foo: 'bar' }, { convert: true })
// === { value: { org_id: 5, foo: 'bar' } }

// coercion fails when inside `alternatives`
joi.alternatives().try(
   joi.object({ org_id: joi.number().required() }).unknown(),
   joi.object({ foo: joi.string().required() }).unknown()
).match('all').validate({ org_id: '5', foo: 'bar' }, { convert: true })
// === { value: { org_id: '5', foo: 'bar' } }

What was the result you got?

org_id: '5'

What result did you expect?

org_ig: 5

Activity

nlundquist

nlundquist commented on Mar 11, 2021

@nlundquist
Author

the only straightforward resolution i can come up with is conditionally merging the matched subschema values only when their properties vary from the original value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @nlundquist

      Issue actions

        coercions during alternative match leads to unexpected results · Issue #2579 · hapijs/joi