feat(server): check additional exif date tags #19216
Merged
+1,213
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for UTC date tags (GPSDateTime, DateTimeUTC, GPSDateStamp, SonyDateTime2) - This matches tags that exiftool-vendored uses for tzSource in extractTzOffsetFromUTCOffset()
danieldietzler
approved these changes
Jun 18, 2025
| 'SourceImageCreateTime' as keyof Tags, | ||
| ]; | ||
| 'SourceImageCreateTime', | ||
| ] as Array<keyof ImmichTags>; |
There was a problem hiding this comment.
Why did you change this from a type hint to casting the array? With the old way you'd get autocompletion/type hints inside the array which I think is valuable.
| try { | ||
| const imagePath = join(targetDir, image.filename); | ||
|
|
||
| // Create unique JPEG file using Sharp |
There was a problem hiding this comment.
We already have a thing for that https://github.com/immich-app/immich/blob/main/e2e/src/generators.ts#L24-L31 so no need to pull sharp in for that.
There was a problem hiding this comment.
PNG images can't have exif
I tried constructing 1 pixel jpg from bytes and sharp always complained of invalid headers or other corruption. So I just decided to use sharp. It's not a new dependency. We already use it :)
alextran1502
approved these changes
Jun 25, 2025
|
Thanks! I have some pictures from Apple devices with only GPSDateTime tags, this should solve the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exiftool-vendoredbehavior when extracting timezone for an image. (extractTzOffsetFromUTCOffset())GPSDateTimeDateTimeUTCSonyDateTime2Note: Date-only or Time-only tags will not be considered as a valid DateTime source, but they will still be used to extract the timezone offset by exiftool-vendored.
Fixes the issue reported with the sample photo here: #12650 (comment)