chore: speedup devcontainer start #19406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
reviewed
Jun 21, 2025
server/Dockerfile
Outdated
| USER node | ||
| COPY --chown=node:node .. /tmp/create-dep-cache/ | ||
| WORKDIR /tmp/create-dep-cache | ||
| RUN make install-all && rm -rf /tmp/create-dep-cache |
There was a problem hiding this comment.
Is the cache implicitly created elsewhere in the container (outside of the rm'd dir)?
There was a problem hiding this comment.
The cache is automatically created by npm whenever it does anything. So, in this case, cache created by make install-all -- then the /tmp folder that was created solely for it to cache things is removed, but the artifacts it cached live on in ~/.npm
bo0tzz
approved these changes
Jun 24, 2025
zackpollard
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.