Skip to content

feat: new timeline multi-selection #19443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 24, 2025
Merged

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Jun 22, 2025

Implement multi-selection logic for the new timeline

@alextran1502 alextran1502 force-pushed the newtimeline-multi-selection branch from 52097f1 to d65ff97 Compare June 23, 2025 20:47
Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

height: height,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
mainAxisAlignment: MainAxisAlignment.spaceAround,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try MainAxisAlignment.spacedBetween? The space between the month and day segment when the asset is grouped by Month + day is higher than what we currently have

@alextran1502 alextran1502 merged commit 9ca31ab into main Jun 24, 2025
47 checks passed
@alextran1502 alextran1502 deleted the newtimeline-multi-selection branch June 24, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants