Skip to content

Android: Fixes #12484: Fix cursor jumps to the beginning of inputs on tap #12499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jun 12, 2025

Summary

This pull request removes a workaround that broke focus behavior after the upgrade to React Native 0.79. The workaround originally resolved a cursor placement issue in long multi-line TextInputs (see facebook/react-native#29911).

Note: Joplin no longer uses a multiline <TextInput by default for the main editor, so facebook/react-native#29911 should be less likely to impact users. However, if the plain text editor is enabled in settings > general, facebook/react-native#29911 still seems to affect Joplin.

Fixes #12484.

Testing plan

  1. Open a note.
  2. Open the note editor.
  3. Show the search bar.
  4. Search for something.
  5. Tap the end of the search bar.
  6. Verify that the cursor is positioned at the end of the search bar.
  7. Tap the end of the note titlebar.
  8. Verify that the cursor is positioned at the end of the titlebar.
  9. Enable "Use the plain text editor" in settings > note.
  10. Open a long note.
  11. Open the note editor.
  12. Tap on a paragraph.
  13. Verify that the cursor was moved to the location of the tap.

@mrjo118
Copy link
Contributor

mrjo118 commented Jun 12, 2025

On some versions of Android 6, the user had to use the plain text editor to get note editing to work. However Android 6 will be desupported in Joplin 3.4 due to the upgrade to rn 0.79. That's definately something to mention in the release notes

@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Fixes #12484: Fix cursor jumps to the beginning of inputs on tap Android: Fixes #12484: Fix cursor jumps to the beginning of inputs on tap Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: When focusing on any TextInput, the cursor position moves to the start of the value
2 participants