Desktop: Resolves #10763: Permanent notebook deletion implemented #12508
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new command was added to the gui when right clicking a folder in the trash, enabling the user to permanently delete it, along with other folders and notes inside it. The command calls a function that deletes the folder as well as anything that it contains. Co-autored-by: Pedro Dias <pedro.miguel.ramalho.dias@tecnico.ulisboa.pt>
laurent22
reviewed
Jun 28, 2025
| @@ -163,6 +163,28 @@ export default class Folder extends BaseItem { | |||
| }); | |||
| } | |||
|
|
|||
| public static async permanentlyDeleteFolder(folderId: string, sourceDescription: string) { | |||
There was a problem hiding this comment.
I'll need to review this more in details but just now I'm not sure what's the difference between this and calling Folder.delete() along with deleteChildren and toTrash=false? And if Folder.delete doesn't already do this then maybe that's the function that needs to be fixed?
Also it should not be called "permanentlyDelete". Permanent deletion is a user-facing concept that should not appear in code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially fixes #10763 by adding a "permanently delete notebook" option on the desktop app.
Changes:
Added a permanentlyDeleteFolder command to packages/app-desktop/gui/WindowCommandsAndDialogs/commands.
Added a permanentlyDeleteFolder function to packages/lib/models/Folder.ts which deletes all notes inside a selected folder, then recursively calls itself again for every subfolder inside the selected folder, and finally deletes the folder itself.
Steps to test the feature:
Expected behavior:
The permanently deleted notebook, along with everything inside it, should be gone from the trash.
0605.1.2.mp4