Skip to content

Cli: Remove setting default value for Setting not used by the CLI #12548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Jun 16, 2025

Summary

In the Desktop: Performance: Faster startup and smaller application size it was introduced a new constant pluginAssetDir, which seems to be causing some issue with the desktop configure, like related in the parent issue.

While trying to find a solution, I didn't find a reason why the constant needed to be set on app-cli as doesn't seems to be used anywhere there since we don't support the HTML exporter there and neither plugins.

Testing

To test the change I run all automated tests and made some manual ones like:

Test 1

  1. Remove the ~/.config/joplindev directory
  2. Starting the app-cli application
  3. Create notebook, note, edit note, etc.

Test 2

  1. Remove the ~/.config/joplindev directory
  2. Starting the app-cli application
  3. Create notebook, note, edit note, etc.
  4. Export the note to md, jex and raw format

@personalizedrefrigerator
Copy link
Collaborator

Thank you for working on this!

it was introduced a new constant pluginAssetDir, which seems to be causing some issue with the desktop configure, like related in the parent issue.

#12545 includes an "about" section with information about the desktop app. This section marks the app as based on 24df674, which does not include 86ee95a as a parent commit. Since it wasn't included in this version of the application, I don't think the pluginAssetDir change could have caused the linked issue (though it could have caused a similar issue in later versions of the app :) ).

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jun 17, 2025

While trying to find a solution, I didn't find a reason why the constant needed to be set on app-cli as doesn't seems to be used anywhere there since we don't support the HTML exporter there and neither plugins.

Cli: Fixes #12545:

For issue tracking purposes, I would suggest removing "Fixes #12545" from the title and summary, as this change should not affect the desktop app.

@pedr pedr changed the title Cli: Fixes #12545: Remove setting default value for Setting not used by the CLI Cli: Remove setting default value for Setting not used by the CLI Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants