Mobile: Implement tag screen redesign #12551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compact mode more closely matches the design for the tag editor in the smart notebook scanner screen.
|
Converting back to a draft — there are a few style-related issues on Android. |
Comment on lines
+12
to
+14
| export enum TagEditorMode { | ||
| Large, | ||
| Compact, |
There was a problem hiding this comment.
The tag editor dialog currently uses the Large mode. The Compact mode makes the tag editor take up less space and is used in the document scanner screen (to be added in a separate pull request).
7 tasks
Adds a brief delay before removing tags, which **may** fix a focus issue on iOS.
…rollView
This change:
- Implements a custom FlatList, resolving a warning about including
FlatLists within ScrollViews causing issues. See comment.
- This also allows for changing the DOM structure of search results on
web, which should improve accessibility.
- Adds announcements on iOS and Android announcing which result is
selected. This particular change still needs to be tested on iOS, but
seems to work well on Android with TalkBack.
The linter did not run on `git rebase --continue`. This commit fixes a linter error separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This work-in-progress pull request implements a redesign of the tag management screen. The tag management and combobox components are designed such that they can be used in contexts other than the tag management screen.
A version of this pull request has been deployed to https://personalizedrefrigerator.github.io/joplin/web-client/.
Tasks:
Screenshots (web)
Searching for a tag:
Searching for a tag already added to the note:
Searching for a tag (dark mode):
Searching for a tag with no results:
Empty search, note with no tags: Note that the highlight below is added by a web browser to indicate focus — it's likely different from the focus style on Android/iOS.
Accessibility notes